cbrs UI test pr (meant to be used to play around, won't merge) #7274

xurui-c · 2025-07-10T02:11:46Z

codecov · 2025-07-10T02:18:16Z

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
1	1	0	0

View the top 1 failed test(s) by shortest run time

::tests.query.allocation_policies.test_allocation_policy_base

Stack Traces | 0s run time

ImportError while importing test module '.../query/allocation_policies/test_allocation_policy_base.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
.../local/lib/python3.11.../site-packages/_pytest/python.py:493: in importtestmodule
    mod = import_path(
.../local/lib/python3.11.../site-packages/_pytest/pathlib.py:582: in import_path
    importlib.import_module(module_name)
.../local/lib/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1204: in _gcd_import
    ???
<frozen importlib._bootstrap>:1176: in _find_and_load
    ???
<frozen importlib._bootstrap>:1147: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:690: in _load_unlocked
    ???
.../local/lib/python3.11.../_pytest/assertion/rewrite.py:184: in exec_module
    exec(co, module.__dict__)
.../query/allocation_policies/test_allocation_policy_base.py:8: in <module>
    from snuba.query.allocation_policies import (
E   ImportError: cannot import name 'InvalidPolicyConfig' from 'snuba.query.allocation_policies' (.../query/allocation_policies/__init__.py)

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

volokluev · 2025-07-31T20:12:28Z

snuba/query/configuration.py

@@ -0,0 +1,218 @@
+from dataclasses import dataclass, field


wrong folder, find a better place for it or make it

volokluev · 2025-07-31T20:13:14Z

snuba/query/configuration.py

+
+
+@dataclass()
+class Configuration:


vibe: this is a pretty generic name for something, may be helpful to make it more specific

at the very least, you should explain what this is

volokluev · 2025-07-31T20:14:16Z

snuba/query/configuration.py

+        }
+
+
+class ConfigurableComponent:


usage example in the docstring

volokluev · 2025-07-31T20:15:56Z

snuba/query/configuration.py

+    def get_config_value(
+        self, config_key: str, params: dict[str, Any] = {}, validate: bool = True
+    ) -> Any:
+        pass
+
+    def set_config_value(
+        self,
+        config_key: str,
+        value: Any,
+        params: dict[str, Any] = {},
+        user: str | None = None,
+    ) -> None:
+        pass


these should not have to implemented by the user, should be plug and play

volokluev · 2025-07-31T20:16:39Z

snuba/query/configuration.py

+            key = key.replace(delimiter_char, escape_sequence)
+        return key
+
+    def _build_runtime_config_key(self, config: str, params: dict[str, Any]) -> str:


this should probably include the component name

volokluev · 2025-07-31T20:19:15Z

snuba/query/configuration.py

+        # what is this configurable component?
+        # allocation policy? routing strategy? strategy selector?
+        return self.__class__.__name__


this should be what runtime_config_prefix is

volokluev · 2025-07-31T20:20:28Z

snuba/web/rpc/storage_routing/routing_strategies/storage_routing.py

+        self._configurations = [
+            RoutingStrategyConfig(
+                name="max_load",
+                description="The maximum load we allow the Clickhouse cluster to reach",
+                value_type=int,
+                default=100,
+            ),
+        ]


return this from get_configurations

volokluev · 2025-07-31T20:23:25Z

snuba/query/allocation_policies/__init__.py

+    def component_namespace(self) -> str:
+        return "allocation_policy"
+


This is going to ignore all existing allocation policy configurations. Make sure they are preserved

volokluev · 2025-07-31T20:26:38Z

snuba/admin/static/capacity_management/types.tsx

+interface ConfigurableComponent {
+  type: string;
+  name: string;
+  configs: Configuration[];
+  optional_config_definitions: OptionalConfigurationDefinition[];
+};


if you're making a more generic thing, it should not be housed under capacity management

volokluev · 2025-07-31T20:35:58Z

snuba/admin/static/capacity_management/index.tsx

+            entity={{ type: "storage", name: selectedStorage }}
+            configurable_component={policy}


this should not be hardcoded, the configurable component should return its type

xurui-c force-pushed the rachel/ui branch 2 times, most recently from b84844a to ed9b838 Compare July 10, 2025 02:40

feat(cbrs): UI

3bcf06d

xurui-c force-pushed the rachel/ui branch from ed9b838 to 3bcf06d Compare July 10, 2025 03:29

Rachel Chen added 4 commits July 16, 2025 23:16

taking a break

6e9cb7b

bug

c05d109

whats going on

3dc3e12

fixed params[]

d0d12c2

xurui-c force-pushed the rachel/ui branch 3 times, most recently from f5fbbd4 to ea79b3e Compare July 31, 2025 18:59

got rid of print statements, add new next

520adfa

xurui-c force-pushed the rachel/ui branch from ea79b3e to 520adfa Compare July 31, 2025 19:02

volokluev reviewed Jul 31, 2025

View reviewed changes

snuba/query/configuration.py

}

class ConfigurableComponent:

Copy link

Member

volokluev Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usage example in the docstring

volokluev reviewed Jul 31, 2025

View reviewed changes

pause

cd7b5b6

xurui-c changed the title ~~feat(cbrs): UI~~ cbrs UI test pr (meant to be used to play around, won't merge) Aug 3, 2025

phacops force-pushed the master branch from 7fca603 to c8950ad Compare September 7, 2025 04:38

		def component_namespace(self) -> str:
		return "allocation_policy"

		entity={{ type: "storage", name: selectedStorage }}
		configurable_component={policy}

Uh oh!

cbrs UI test pr (meant to be used to play around, won't merge) #7274

Are you sure you want to change the base?

cbrs UI test pr (meant to be used to play around, won't merge) #7274

Uh oh!

Conversation

xurui-c commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 1 Tests Failed:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

xurui-c commented Jul 10, 2025 •

edited

Loading

codecov bot commented Jul 10, 2025 •

edited

Loading